Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple databases through POSTGRES_DATABASE #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schonert
Copy link

@schonert schonert commented Jan 9, 2024

Added support for multiple databases. I found schicklings approach pretty straightforward.

POSTGRES_DATABASE=database1,database2,database3.

Nothing has changed in how the database is backed up - simply allowing iterating over multiple. It could most likely be optimized - however, this is way better than having multiple docker containers running for different databases.

Simply copied the iterator from https://github.com/schickling/dockerfiles/blob/master/postgres-backup-s3/backup.sh

@schonert
Copy link
Author

@eeshugerman, can I do anything to make this more straightforward for you to review/approve? :)

@marcosviniciuscl
Copy link

I really want this feature, can someone approve this pull request, please!!! @eeshugerman

@purejamie
Copy link

Hi @eeshugerman - any chance we can get this merged into base?

@eeshugerman
Copy link
Owner

Hi all, sorry about the lack of communication here. While I do intend to merge this (or something like it -- see also #38) eventually, I can't give any timeframe commitments. I want to get integration tests in place before merging any more features, and I'm not sure when I'll get to that. In the meantime, I encourage forking the project if you really need this.

@schonert
Copy link
Author

schonert commented Jun 1, 2024

Totally fair :-)
Planed out how you'd like to do tests or would you be interested in a PR from the community?

I'm afraid I wouldn't have a clue at this point - just in case someone why did, came along and saved our lost sounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants