Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use backup directory, refact dockerfile #16

Closed
wants to merge 1 commit into from
Closed

feat: Use backup directory, refact dockerfile #16

wants to merge 1 commit into from

Conversation

pratikbin
Copy link

No description provided.

This was referenced May 4, 2022
@eeshugerman
Copy link
Owner

Hi, thanks for the PR! #17 is a usecase I'm interested in supporting. But I can't accept this as is; there are far too many unnecessary, unrelated changes. If you provide a patch with minimal changes for #17, I will consider merging.

@pratikbin pratikbin changed the title feat: Use backup in directory, refact dockerfile feat: Use backup directory, refact dockerfile May 8, 2022
@pratikbin
Copy link
Author

If you provide a patch with minimal changes for #17, I will consider merging.

There are

Major

  • Move install.sh to dockerfile
  • Add backup directory in backup.sh

Minor

  • chmod +x both backup and restore file, since git preserve permissions

So if you want me to break down these changes in separate PR, then let me know

@pratikbin
Copy link
Author

@eeshugerman Any updates to get this merge ?

@eeshugerman
Copy link
Owner

Hi, sorry for the delay. Thanks for the breakdown of changes here.

I don't want to get rid of install.sh unless we have a good reason to, so I'm not going to merge this as-is.

If you open a separate PR with only the backup/ directory changes, and another PR with only the chmod +x changes, I will likely merge them both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants