Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
EECS 485 has a custom favicon, and other courses' staff may be considering adding favicons to help students find the project-spec tabs in their browsers. This PR allows course staff to configure favicons to be used for all pages on their site.
I also think it would be great to see this feature make its way to the original Primer theme. I've opened pages-themes/primer#42 to request adding this support.
Validation
Pull the branch locally.
Add the following line to
_config.yml
:Run
script/server
and visit http://localhost:4000 —- the site's favicon should display in the browser tab list.Remove the line from
_config.yml
and restartscript/server
. Refresh the page on your browser, and notice that the browser uses a default placeholder favicon in the tab list.