Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for favicons #79

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Add support for favicons #79

merged 2 commits into from
Sep 9, 2020

Conversation

seshrs
Copy link
Member

@seshrs seshrs commented Sep 7, 2020

Context

EECS 485 has a custom favicon, and other courses' staff may be considering adding favicons to help students find the project-spec tabs in their browsers. This PR allows course staff to configure favicons to be used for all pages on their site.

I also think it would be great to see this feature make its way to the original Primer theme. I've opened pages-themes/primer#42 to request adding this support.

Validation

Pull the branch locally.

  1. Add the following line to _config.yml:

    favicon: https://eecs485staff.github.io/eecs485.org/favicon.ico

    Run script/server and visit http://localhost:4000 —- the site's favicon should display in the browser tab list.

    image

  2. Remove the line from _config.yml and restart script/server. Refresh the page on your browser, and notice that the browser uses a default placeholder favicon in the tab list.

    image

@seshrs seshrs added enhancement New feature or request semver/minor Pull Request proposes "minor" change labels Sep 7, 2020
@seshrs seshrs added this to the WN 2021 milestone Sep 7, 2020
@seshrs seshrs merged commit 006593e into develop Sep 9, 2020
@seshrs seshrs deleted the favicon branch September 9, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver/minor Pull Request proposes "minor" change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant