Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate edx sphinx theme #220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Aug 6, 2024

Description:
This PR deprecated edx-sphinx-theme and replaces it with sphinx-book-theme

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the Python version in tox.ini and setuptools as well. Also it would be better to run make upgrade so all requirement files get updated if we're updating the Python version.
Since platform has been updated to Python 3.11, let's update this package to 3.11 or 3.12 as well.

@huniafatima-arbi
Copy link
Member Author

Let's update the Python version in tox.ini and setuptools as well. Also it would be better to run make upgrade so all requirement files get updated if we're updating the Python version. Since platform has been updated to Python 3.11, let's update this package to 3.11 or 3.12 as well.

@UsamaSadiq python and setuptools version is updated. Please give it a review.

Notes
  • codecov is failing in CI due to rate limit. Currently code coverage failure keeps the CI green for the visibility of other tests. Will revert is once PR is approved.
  • Will update release in changelog when the PR is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants