Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove secure repo and fetch secrets from AWS for analytics je… #1681

Merged

Conversation

syedimranhassan
Copy link
Contributor

…nkins jobs

@syedimranhassan
Copy link
Contributor Author

@HassanJaveed84 We are in the process of eliminating the secure repository from Jenkins and transitioning to fetching secrets from AWS. I've implemented adjustments for DE jobs that rely on the "user-retirement-secure" repository. These changes have been tested on jobs located in tools-Jenkins (PR for that change). I would appreciate your review of these modifications.

@syedimranhassan syedimranhassan force-pushed the ihassan/CLOUDSEC-34_fetch_secret_aws_analytics_jenkins branch from a5695d7 to db1fce6 Compare October 25, 2023 15:22
Copy link
Contributor

@Hamza442 Hamza442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedimranhassan syedimranhassan force-pushed the ihassan/CLOUDSEC-34_fetch_secret_aws_analytics_jenkins branch from b6b463f to d5655cc Compare October 27, 2023 07:22
@syedimranhassan syedimranhassan merged commit f78d2f5 into master Oct 27, 2023
@syedimranhassan syedimranhassan deleted the ihassan/CLOUDSEC-34_fetch_secret_aws_analytics_jenkins branch October 27, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants