Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove logs from order history API #297

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

NoyanAziz
Copy link
Contributor

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

Copy link

github-actions bot commented Nov 18, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  pipeline.py
  commerce_coordinator/apps/ecommerce
  clients.py
  pipeline.py
  commerce_coordinator/apps/frontend_app_ecommerce
  views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoyanAziz NoyanAziz merged commit 0bde72a into main Nov 20, 2024
8 checks passed
@NoyanAziz NoyanAziz deleted the naziz1/SONIC-740/remove-order-history-logs branch November 20, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants