Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additional logging #253

Merged
merged 5 commits into from
Jul 15, 2024
Merged

feat: additional logging #253

merged 5 commits into from
Jul 15, 2024

Conversation

JadeyOlivier
Copy link
Member

Description: Additional logging for views and client flows
JIRA: https://2u-internal.atlassian.net/browse/SONIC-344

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  filters.py
  pipeline.py
  serializers.py
  views.py
  commerce_coordinator/apps/commercetools/sub_messages
  tasks.py
  commerce_coordinator/apps/commercetools/tests
  test_clients.py
  test_pipeline.py
  commerce_coordinator/apps/commercetools/tests/sub_messages
  test_tasks.py
  commerce_coordinator/apps/lms
  clients.py
  views.py
  commerce_coordinator/apps/stripe
  pipeline.py
Project Total  

This report was generated by python-coverage-comment-action

grmartin
grmartin approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@grmartin grmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the PII Question

commerce_coordinator/apps/lms/views.py Show resolved Hide resolved
@JadeyOlivier JadeyOlivier merged commit b2be7e2 into main Jul 15, 2024
9 checks passed
@JadeyOlivier JadeyOlivier deleted the jolivier/SONIC-344/Logging-In-Views branch July 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grmartin grmartin grmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JadeyOlivier @grmartin