fix: fixes

edx · Dec 13, 2024 · df9f9cc · df9f9cc
1 parent 1d98251
commit df9f9cc
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/commerce_coordinator/apps/paypal/views.py b/commerce_coordinator/apps/paypal/views.py
@@ -41,12 +41,12 @@ def _get_certificate(self, url):
         """
         Get certificate from the given URL
         """
+        if not self._is_valid_url(url):
+            raise ValueError("Invalid or untrusted URL provided")
         try:
-            if not self._is_valid_url(url):
-                raise ValueError("Invalid or untrusted URL provided") from e
             cache = KeyValueCache.objects.get(cache_key=url)
             return cache.value
-        except Exception as e:  # pylint: disable=broad-exception-caught
+        except KeyValueCache.DoesNotExist:
             r = requests.get(url) # pylint: disable=missing-timeout
             KeyValueCache.objects.create(cache_key=url, cache_value=r.text)
             return r.text