Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for editing meta data #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

abdobargush
Copy link

Add support for editing meta data (title, description) after being fetched.
Using allowMetaEdit as a config parameter to enable and disable editing.

@SalahAdDin
Copy link

Add support for editing meta data (title, description) after being fetched. Using allowMetaEdit as a config parameter to enable and disable editing.

Still waiting for this update.

@abdobargush could you check the conflicts, please?

@abdobargush
Copy link
Author

@SalahAdDin Sorry for the delay, solved!

@SalahAdDin
Copy link

@SalahAdDin Sorry for the delay, solved!

Now, we have to wait for the EditorJS team to merge and release a new version.

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please, follow our code style and remove changes unrelated to the feature you're adding.

@abdobargush
Copy link
Author

@neSpecc Can you please share .editorconfig or .prettierrc or indicate the code style that you are using?

@neSpecc
Copy link
Contributor

neSpecc commented Oct 24, 2022

@neSpecc Can you please share .editorconfig or .prettierrc or indicate the code style that you are using?

Pull the master please, I've added the lint and lint:fix eslint commands to the package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants