replace copy buttons with copy command#261
Merged
Merged
Conversation
zikajk
force-pushed
the
add-eca-chat-copy-at-point-command
branch
from
e4a23ea to
e556182
Compare
Remove visible copy controls from chat output and add `eca-chat-copy-at-point` on `C-c C-w`, backed by hidden response/code-block copy scopes.
zikajk
force-pushed
the
add-eca-chat-copy-at-point-command
branch
from
e556182 to
e7f71df
Compare
`string-pixel-width' and `buffer-text-pixel-size' are both Emacs 29+ symbols. package-lint errors on the latter since we declare `(emacs "28.1")', failing CI; and at runtime on Emacs 28.x the code would signal a void-function error. Wrap each in an `fboundp' guard and fall back to `string-width' when neither is available.
zikajk
force-pushed
the
add-eca-chat-copy-at-point-command
branch
from
4a979dc to
17d47d9
Compare
`string-pixel-width' and `buffer-text-pixel-size' are both Emacs 29+. Remove dead `buffer-text-pixel-size' branch and skip pixel right-alignment on 28.x, where `string-width' fallback would push right segments past the window edge. Guard pixel-specific tests.
zikajk
force-pushed
the
add-eca-chat-copy-at-point-command
branch
from
17d47d9 to
4cd74f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove visible copy controls from chat output and add
eca-chat-copy-at-pointonC-c C-w, backed by hidden response/code-block copy scopes.