Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationDef as macros. #223

Merged
merged 9 commits into from
Mar 24, 2025
Merged

OperationDef as macros. #223

merged 9 commits into from
Mar 24, 2025

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Mar 17, 2025

Switch current OperationDef construction logic to macros - meaning the OperationDef value is constructed at macro-execution time.
Thus we can use it directly as input to the codegen macros, and actually erase the OperationDef value at runtime, only keeping the necesarry infromatin as litterals.

Leverage this to refactor a few first things in the codegen macros too.

@baymaks, bonus point, this indeed generates:

  public java.lang.String getName();
    Code:
       0: ldc           #28                 // String cmathv2.mulv2
       2: areturn

@PapyChacal PapyChacal force-pushed the emilien/opdef-macro branch from 01f457a to 714e266 Compare March 22, 2025 16:16
@PapyChacal PapyChacal marked this pull request as ready for review March 23, 2025 13:42
@PapyChacal PapyChacal changed the title Emilien/opdef macro OperationDef as macros. Mar 23, 2025
@PapyChacal PapyChacal requested a review from baymaks March 23, 2025 13:43
@PapyChacal PapyChacal self-assigned this Mar 23, 2025
Copy link
Collaborator

@baymaks baymaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 😎 👍

@PapyChacal PapyChacal merged commit fcc5983 into main Mar 24, 2025
4 checks passed
@PapyChacal PapyChacal deleted the emilien/opdef-macro branch March 24, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants