Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Get All DeviceProfile BasicInfo API #4817

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

weichou1229
Copy link
Member

The Device Profile sometimes is very large with lots of device resources. Device Profile query may take lots of time and cause request timeout. A new GET /deviceprofile/basicinfo/all API would be helpful for the UI integration

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

  • run core-metadata
  • add device profile
  • query the API /api/v3/deviceprofile/basicinfo/all

New Dependency Instructions (If applicable)

@weichou1229
Copy link
Member Author

This PR is based on the core-contracts changes edgexfoundry/go-mod-core-contracts#903

The Device Profile sometimes is very large with lots of device resources.
Device Profile query may take lots of time and cause request timeout.
A new GET /deviceprofile/basicinfo/all API would be helpful for the UI integration

Closes edgexfoundry#4814

Signed-off-by: bruce <[email protected]>
@jumpingliu
Copy link
Contributor

relates to #4814

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 41.55%. Comparing base (d3e93d2) to head (9494c74).

Files Patch % Lines
...nal/core/metadata/controller/http/deviceprofile.go 0.00% 15 Missing ⚠️
...nternal/core/metadata/application/deviceprofile.go 0.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4817      +/-   ##
==========================================
- Coverage   41.66%   41.55%   -0.11%     
==========================================
  Files         105      105              
  Lines        9876     9902      +26     
==========================================
  Hits         4115     4115              
- Misses       5408     5434      +26     
  Partials      353      353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit cd4dcca into edgexfoundry:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants