Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to gel #331

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Rename to gel #331

wants to merge 18 commits into from

Conversation

fmoor
Copy link
Member

@fmoor fmoor commented Jan 8, 2025

Renames edgedb to gel in everything that is public facing code or docs. The tests are expected to fail since there are a few tests that rely on the new gel-go repo existing which it doesn't yet.

I tried to limit each commit to a single logical change to facilitate review.

@fmoor fmoor requested review from fantix and nsidnev January 8, 2025 22:59
Copy link
Member

@nsidnev nsidnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just 1 question

@@ -1,12 +1,12 @@
// Code generated by github.com/edgedb/edgedb-go/cmd/edgeql-go DO NOT EDIT.
// Code generated by github.com/geldata/gel-go/cmd/edgeql-go DO NOT EDIT.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to update dependencies in test projects (from cmd/edgeql-go/testdata/mixedcaps/test-project1/go.mod) after getting a new repo, do I get it right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea the plan is to not merge this until we have the new repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I will also have to update the go.mod & go.sum files. That is currently a pain to do so I'll wait until the new repo is set up and I can make the tests pass.

rstdocs/index.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants