Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not allow set lt at rj45 port #6

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

PJHsieh
Copy link

@PJHsieh PJHsieh commented Jul 8, 2024

What I did

Skip setting link-training on RJ-45 interfaces

How I did it

Check the interface type. If the interface is RJ-45, just return error.

How to verify it

Enable link-training or disable link-training on RJ45 interfaces, error message shall be shown.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

bryan1978 and others added 2 commits August 24, 2023 06:17
Fix yang model checking failed for MGMT_PORT #2601
[storm_control] CLI show error when trying to show the configuration with the specified interface #2729
* Skip RJ-45 interfaces
* Add unit test case to resolve coverage error
@PJHsieh PJHsieh closed this Jul 8, 2024
@PJHsieh PJHsieh reopened this Jul 8, 2024
@PJHsieh PJHsieh changed the base branch from 202211.0 to 202311.X July 8, 2024 08:08
@PJHsieh
Copy link
Author

PJHsieh commented Jul 8, 2024

Link to sonic-net/sonic-utilities#3404

@PJHsieh PJHsieh merged commit 22ca1a3 into edge-core:202311.X Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants