(refactor): Replace addr_of_mut with MaybeUninit::as_mut_ptr #377
+177
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-thakkar
force-pushed
the
as_mut_ptr
branch
from
5e7db13
to
03bc8b4
Compare
Use MaybeUninit::as_mut_ptr as it's a more safer option to avoid any potential bugs with respect to uninitialized memory. Signed-off-by: Vaishali Thakkar <[email protected]>
v-thakkar
force-pushed
the
as_mut_ptr
branch
from
03bc8b4
to
4547340
Compare
v-thakkar
changed the title
|
Hi! I just saw this. We are restructuring this repository to make contributions and work with the Xen community a bit more feasible, so this will require updates, but thank you so much for the contribution! |
|
@azenla Sure, sounds good. I'll close the PR and will open a new one once all updates to the repo are in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MaybeUninit::as_mut_ptr as it's a more safer option to avoid any potential bugs with respect to uninitialized memory.
Fixes #182