Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add REVE1, REVE2, IDEA and MKK modules #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marcoroth
Copy link

Hey there!

Thanks for maintaining this helpful extension!

I've got some undefined modules and figured to add them here too.

I guess because I downloaded the latest html files that it added a bunch of new modules and changed the types of existing ones. If that doesn't make sense feel free to yoink 72d8be5 and generate the data again ;)

Copy link
Owner

@eddex eddex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for also updating the script @marcoroth 👍

@@ -158,13 +169,16 @@
"PRAXIS_3/6": "Projektmodul",
"PRAXIS_VT": "Erweiterungsmodul",
"PRAXIS_VTZ": "Projektmodul",
"PREN1": "Projektmodul",
"PREN1": "Erweiterungsmodul",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look right, @Lextum please check...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parser still works fine. PREN1 is now actually listed in the section "Erweiterungsmodule" for whatever reason.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case the required minimum credits for "Projektmodule" and "Erweiterungsmodule" have changed. We need to check that to make sure the calculations are still correct.

Are there still students studying right now where PREN is counted as "Projektmodul"? Because then we have the salad! 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new module called iPREN1 and iPREN2 which are more focused on IT according to email. We still have the problem, that we can't distinguish when the module was taken and which type it had back then.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we might need an option to manually change the type of a module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants