firstModule detection fix #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-1283029378 -Fixed the first semester calculation -> Check comment for detailed description of fix -Also general cleanup as my ide warned me about simple things
eddex
reviewed
Oct 19, 2022
Comment on lines
+18
to
+20
| isNotInfoSemester: (hsluModuleName) => { | ||
| return !hsluModuleName.includes('INFO') | ||
| }, |
There was a problem hiding this comment.
When a method returns a bool, always think of what it should check, not what it shouldn't. This makes the code more readable.
Suggested change
| isNotInfoSemester: (hsluModuleName) => { | |
| return !hsluModuleName.includes('INFO') | |
| }, | |
| isInfoModule: (hsluModuleName) => { | |
| return hsluModuleName.includes('INFO') | |
| }, |
| const includesH = hsluModuleName.split('.')[2].includes('H'); | ||
| const includesF = hsluModuleName.split('.')[2].includes('F'); | ||
| return includesH || includesF ? includesH : undefined; | ||
| return hsluModuleName.split('.')[2].includes('H') && ModuleParser.isNotInfoSemester(hsluModuleName); |
There was a problem hiding this comment.
Suggested change
| return hsluModuleName.split('.')[2].includes('H') && ModuleParser.isNotInfoSemester(hsluModuleName); | |
| return hsluModuleName.split('.')[2].includes('H') && !ModuleParser.isInfoModule(hsluModuleName); |
| * Modules are marked with 'F' for 'Frühlingssemester' (spring). | ||
| */ | ||
| isSpringSemester: (hsluModuleName) => { | ||
| return hsluModuleName.split('.')[2].includes('F') && ModuleParser.isNotInfoSemester(hsluModuleName); |
There was a problem hiding this comment.
Suggested change
| return hsluModuleName.split('.')[2].includes('F') && ModuleParser.isNotInfoSemester(hsluModuleName); | |
| return hsluModuleName.split('.')[2].includes('F') && !ModuleParser.isInfoModule(hsluModuleName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the firstModule detection to also detect spring starts and ignore any module containing "INFO" in the "anlassnumber" field. For more details on the fix check out my comment: #99 (comment)
Related issues are:
#99
#95