Fix for https://github.com/edcarroll/ng2-semantic-ui/issues/185 #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en running with universal. Check "window" browser to prevent errors when running with universal. Add typescript definition of the closest polyfill
|
Thank you for the PR!! 🎉 will get round to reviewing this in a couple of days (sorry for the delay, slammed with work atm) |
|
Has this been forgotten about? |
|
Hi, What is the status on this? Will it be merged or not? Thank you! |
|
Guys, can someone approve this request? |
OliverEivak
pushed a commit
to OliverEivak/ng2-semantic-ui
that referenced
this pull request
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get semantic-ui working with universal (see #185)
Change type from MouseEvent/KeyboardEvent to any to prevent errors when running with universal.
Check "window" browser to prevent errors when running with universal.
Add typescript definition of the closest polyfill