Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Rllib version #220

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Limit Rllib version #220

merged 5 commits into from
Jan 22, 2025

Conversation

Ivan-267
Copy link
Collaborator

A temporary fix for Rllib, limits the version to a version that has passed tests previously.

@Ivan-267 Ivan-267 requested a review from edbeeching December 15, 2024 22:55
@Ivan-267
Copy link
Collaborator Author

Ivan-267 commented Jan 19, 2025

Note: May need pip install torch==2.1.0 (potentially) and pip install onnx==1.16.1 as well in order for onnx export to work.

Tests compatibility with older onnx which works well with the rllib example script.
@Ivan-267
Copy link
Collaborator Author

@edbeeching Should be ready for merging now, assuming the tests pass. It should work with that version, and at a future point we can consider an upgrade to newer Rllib.

Copy link
Owner

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ivan-267 Ivan-267 merged commit f439635 into main Jan 22, 2025
13 checks passed
@Ivan-267 Ivan-267 deleted the limit-rllib-version branch January 22, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants