This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Improve Component types to allow for type inference on schema properties #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should enable type inference on component schema properties, while not changing the way Components are constructed.
Now when using Typescript and creating a component like:
class Position extends Component<{ x: number, y: number }>{}
for any new instance ofPosition
typescript will recognize all baseComponent
properties, as well as the properties specified in the Component generic type parameter (the schema). (in this case,new Position().x
will resolve tonumber
)Example usage (type declarations copied from PR)
Fixes #249