Static converters

[jlabedo]

Why is this change proposed?

Allow defining static function for converters, eg. :

class PriceWasChanged
{
    public function __construct(private string $productId, private float $price) {}

    public function getProductId(): string
    {
        return $this->productId;
    }

    public function getPrice(): float
    {
        return $this->price;
    }

    #[Converter]
    public static function fromArray(array $data): self
    {
        return new self($data['productId'], $data['price']);
    }

    #[Converter]
    public static function toArray(self $object): array
    {
        return [
            'productId' => $object->productId,
            'price' => $object->price,
        ];
    }
}

Description of changes

For projecting benchmark: added static converters and disabled JMS that a substantial impact on this benchmark

Pull Request Contribution Terms

• I have read and agree to the contribution terms outlined in CONTRIBUTING.

[lifinsky]

Hi! #523 (comment)

I’ll try to submit two bug reports by the end of the day that blocked us from upgrading from version 1.256 and above.

[dgafka]

What is the use case for allowing converter to work on arrays, instead of specific singular types?
Converter would be called multiple times for given type, meaning string => stdClass, will cover string[] => stdClass[]

[jlabedo]

It's a copy/paste of an existing test case, I'm not changing the behavior here.
But as you mention, I would have liked the converters to only be able to convert from array to object or from object to array (only normalization and denormalization), that would have allowed me to do converter resolution at compile time in #526

[dgafka]

I would have liked the converters to only be able to convert from array to object or from object to array

@jlabedo I don't think we can do that. Things like Enums converted to scalars in headers would stop working.
But you can point me to the place where it will be needed and we think of the solution there

[dgafka]

It's a copy/paste of an existing test case, I'm not changing the behavior here.

Oki then, I would expect this one to fail :)

[jlabedo]

@jlabedo I don't think we can do that. Things like Enums converted to scalars in headers would stop working.

You are right, I meant from scalar to object and from object to scalar. And by scalar I mean int,float,bool,string,arrayOfScalars.

But you can point me to the place where it will be needed and we think of the solution there

Nowhere in Ecotone, but it could be a BC if people have used this feature.

[dgafka]

@jlabedo can you update the docs? You can do it directly in the documention repo, as each merge republishes the doc