Skip to content

Conversation

@pgeier
Copy link

@pgeier pgeier commented Nov 18, 2025

Description

This PR is related to ecmwf/metkit#128 - it uses the new CodesHandle directly instead of eccodes C API.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-198

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-198

@pgeier pgeier force-pushed the feature/METK-145-Refactor-CodesContent branch from 71eeb84 to 414f33c Compare November 20, 2025 08:07
@Ozaq Ozaq force-pushed the feature/METK-145-Refactor-CodesContent branch 2 times, most recently from c9117ad to b8a97dd Compare December 2, 2025 13:45
Copy link
Contributor

@simondsmart simondsmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. very clean.

@pgeier
Copy link
Author

pgeier commented Jan 9, 2026

Do not merge yet.
Due to the dependencies in mars-client-cpp, we need to make some more changes and create an intermediate CodesDataContent first - which will then be renamed to CodesContent in a follow up PR

@pgeier pgeier marked this pull request as draft January 13, 2026 11:36
@pgeier pgeier force-pushed the feature/METK-145-Refactor-CodesContent branch 2 times, most recently from 77dd862 to ccb11f9 Compare January 30, 2026 14:13
@pgeier pgeier force-pushed the feature/METK-145-Refactor-CodesContent branch from ccb11f9 to 86e9648 Compare January 30, 2026 14:21
@pgeier pgeier marked this pull request as ready for review February 2, 2026 14:34
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.33%. Comparing base (8abf5d2) to head (86e9648).

Files with missing lines Patch % Lines
src/fdb5/tools/fdb-patch.cc 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
+ Coverage    73.30%   73.33%   +0.03%     
===========================================
  Files          363      363              
  Lines        21956    21951       -5     
  Branches      2253     2253              
===========================================
+ Hits         16094    16097       +3     
+ Misses        5862     5854       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants