-
Notifications
You must be signed in to change notification settings - Fork 13
Rework of FDB Wipe + Remote FDB Wipe #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ChrisspyB
wants to merge
106
commits into
develop
Choose a base branch
from
wipe-changes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,818
−1,881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default for WipeElementType type_ Co-authored-by: Metin Cakircali <[email protected]>
Due to refactoring the wheel was missing bindings shared object and the z3fdb._internal python module.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #184 +/- ##
===========================================
+ Coverage 72.91% 72.94% +0.03%
===========================================
Files 362 365 +3
Lines 21727 22428 +701
Branches 2242 2309 +67
===========================================
+ Hits 15843 16361 +518
- Misses 5884 6067 +183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4b98995 to
a4e6af0
Compare
FDB-508 Fix merge of daos wipe changes
a4e6af0 to
51e1f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some caveats:
--unsafe-wipe-allwill hit an assert(false) on remote FDB, as I do not want this functionality supported without better testing / some discussion.Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-184
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-184
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-184