Skip to content

Conversation

@ChrisspyB
Copy link
Member

@ChrisspyB ChrisspyB commented Oct 20, 2025

Description

  • Complete rework of the wipe visitor mechanism. We now visit the Catalogue in order to produce a WipeState object, which contains URIs to be deleted/marked as safe. The client then forwards this information to the relevant Stores.
  • This abstraction should allow for mixed Catalogue/Store backends.
  • This PR also adds the corresponding functionality for Wiping in Remote FDB.

Some caveats:

  • There are a couple of TODO's in the code. I will continue chipping away at these.
  • DAOS wipe functionality is broken. This is currently preventing build on the CI. I will fix things so that they build, but further work will be required to reimplement the DAOS wipe.
  • --unsafe-wipe-all will hit an assert(false) on remote FDB, as I do not want this functionality supported without better testing / some discussion.
  • I am currently trying to test the remote functionality.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-184

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-184

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-184

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 77.33415% with 369 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (5fcf81b) to head (51e1f9d).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/fdb5/remote/server/CatalogueHandler.cc 1.04% 95 Missing ⚠️
src/fdb5/daos/DaosStore.cc 64.10% 28 Missing ⚠️
src/fdb5/daos/DaosCatalogue.cc 76.52% 27 Missing ⚠️
src/fdb5/database/WipeState.cc 84.02% 27 Missing ⚠️
src/fdb5/remote/server/StoreHandler.cc 74.52% 27 Missing ⚠️
src/fdb5/api/helpers/WipeIterator.cc 31.57% 26 Missing ⚠️
src/fdb5/remote/client/RemoteCatalogue.cc 46.51% 23 Missing ⚠️
src/fdb5/remote/client/RemoteStore.cc 71.42% 18 Missing ⚠️
src/fdb5/toc/TocStore.cc 84.41% 12 Missing ⚠️
tests/fdb/api/test_auxiliary.cc 91.96% 9 Missing ⚠️
... and 24 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
+ Coverage    72.91%   72.94%   +0.03%     
===========================================
  Files          362      365       +3     
  Lines        21727    22428     +701     
  Branches      2242     2309      +67     
===========================================
+ Hits         15843    16361     +518     
- Misses        5884     6067     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FDB-508 Fix merge of daos wipe changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants