Skip to content

Conversation

@DJDavies2
Copy link
Contributor

Description

Comment out some OpenMP statements when AOCC defined. Needed to get ctests to pass with AOCC compiler.

I am not very happy about this, I wish I understood what the problem actually was.

Resolves #233

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

Copy link
Member

@Ozaq Ozaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @DJDavies2 thanks for your contribution, however before accepting this PR, I think it is required to understand the underlying issue.

Please provide additional information as requested by @wdeconinck in #233. Preferably the AOCC version and cmake settings used to compile so that we can attempt to recreate the issue. Additionally the full cmake / ctest output could be helpful to diagnose the issue.

@wdeconinck
Copy link
Member

As mentioned in issue #233, this is likely not a problem with the aocc compiler. I would not merge this, but rather turn off the OMP feature.
Within a bundle where you may have other projects with the OMP feature, you could be selective for eckit only using the ECKIT_ prefix, as in -DECKIT_ENABLE_OMP=OFF

@DJDavies2
Copy link
Contributor Author

I will switch off OpenMP for eckit for now, thanks.

@DJDavies2 DJDavies2 closed this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ctest failure when compiled with aocc

3 participants