Enable support for HTTP communication between components ECFLOW-1957 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosbento
force-pushed
the
feature/support_http_comms
branch
2 times, most recently
from
b3c3d33
to
5e20a18
Compare
Re ECFLOW-1957
Re ECFLOW-1957
marcosbento
force-pushed
the
feature/support_http_comms
branch
from
5e20a18
to
92016f8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #121 +/- ##
===========================================
- Coverage 47.12% 47.03% -0.10%
===========================================
Files 1182 1181 -1
Lines 93344 93481 +137
Branches 14706 14733 +27
===========================================
- Hits 43992 43972 -20
- Misses 49352 49509 +157 ☔ View full report in Codecov by Sentry. |
Re ECFLOW-1957
marcosbento
force-pushed
the
feature/support_http_comms
branch
3 times, most recently
from
798ae74
to
b1ca0fa
Compare
marcosbento
force-pushed
the
feature/support_http_comms
branch
from
b1ca0fa
to
df873ea
Compare
Also, fix an eventual race condition accessing: - Ecf::state_change_no_ and Ecf::state_modify_no_ Apart from making these global (instead of thread_local), the Http library is restricted to the use of a single thread Re ECFLOW-1957
marcosbento
force-pushed
the
feature/support_http_comms
branch
from
df873ea
to
6d66c4f
Compare
Re ECFLOW-1957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.