define uint64_t type grib_en/decode and use them #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently grib_encode_size_t / grib_decode_size_t are defined and especially on windows where size_t is 64 bit, encode_double_array and decode_double_array use them. So especially for 32 bit linux system, define uint64_t type grib_encode / grib_decode and use them instead of size_t type ones. This method is more portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently grib_encode_size_t / grib_decode_size_t are defined and
especially on windows where size_t is 64 bit,
encode_double_array and decode_double_array use them.
So especially for 32 bit linux system, define uint64_t type grib_encode /
grib_decode and use them instead of size_t type ones. This method is
more portable.
The proposal patch fixes the following test failure on Linux 32 bit:
Forwarded from: https://jira.ecmwf.int/browse/SUP-3561