Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-python.yml: Upgrade GitHub Actions #777

Closed
wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 23, 2023

"3.10" MUST be in quotes in YAML... https://dev.to/hugovk/the-python-3-1-problem-85g


Python 3.12 removes the ssl.wrap_socket() function. https://docs.python.org/3/whatsnew/3.12.html#ssl

Any package that still uses ssl.wrap_socket() is broken and insecure.

% python3.12 ./08-ssl-connect-cert-auth-pw.py python/08-ssl-connect-cert-auth-pw.test

Traceback (most recent call last):
  File "/home/runner/work/paho.mqtt.python/paho.mqtt.python/test/lib/./08-ssl-connect-cert-auth-pw.py", line 25, in <module>
    ssock = paho_test.create_server_socket_ssl(cert_reqs=ssl.CERT_REQUIRED)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/paho.mqtt.python/paho.mqtt.python/test/paho_test.py", line 49, in create_server_socket_ssl
    ssock = ssl.wrap_socket(
            ^^^^^^^^^^^^^^^
AttributeError: module 'ssl' has no attribute 'wrap_socket'

@akx

@akx
Copy link
Contributor

akx commented Dec 23, 2023

@cclauss the wrap_socket() thing is addressed in #771 (as is upgrading the versions)...

@cclauss
Copy link
Contributor Author

cclauss commented Dec 23, 2023

Closing in favor of #771

@cclauss cclauss closed this Dec 23, 2023
@cclauss cclauss deleted the patch-1 branch December 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants