Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua bindings #527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Lua bindings #527

wants to merge 3 commits into from

Conversation

dedok
Copy link

@dedok dedok commented Jun 21, 2016

Issue: #392

Also, when this PR is approved, I'll post some information about this event in lua, luajit, tarantool mailings.

@dedok dedok mentioned this pull request Jun 21, 2016
@@ -20,3 +21,17 @@ package.json
binding.gyp
READMEFIRST
npm-debug.log

# lua files
src/lua/mraaLUA_wrap.cxx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of confused why all these are needed, if you use a build/ directory then everything will get ignored. Let's keep this stuff out unless there's a good reason

Copy link
Author

@dedok dedok Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not use build/ directory :)
Okay if you don't like these changes I can remove them out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building in tree is not recommended for cmake (or any other builds really tbh), any good reason why you can't just build somewhere outside of git or simply add an ignore for your build directory? In any case such stuff doesn't belong in commits adding Lua support so please remove.

@arfoll
Copy link
Contributor

arfoll commented Jun 21, 2016

So this is very cool, thanks. I'm worried there's alot of docs duplication, do the docs build? Also can you rebase all the patches into one and add a sign-off as mentioned in CONTRIBUTING.MD.

Note, do the gpio interupts work? Any plans to support them?

@dedok
Copy link
Author

dedok commented Jun 21, 2016

Note, do the gpio interupts work?

Only AIO, GPIO's read_, write_ is tested.

Any plans to support them?

If some thing does not work I'll fix this. Currently I do not test all features since I need only GPIO read, write and AIO. But in the future my projects will need more MRAA features.
Also where is big chance that somebody from Lua, LuaJit community can help MRAA.

@dedok
Copy link
Author

dedok commented Jun 21, 2016

So this is very cool, thanks. I'm worried there's alot of docs duplication, do the docs build?

Yes I did and I got few warnings, I do not have big knowledge in sphx docs :)

Also can you rebase all the patches into one and add a sign-off as mentioned in CONTRIBUTING.MD.

Only tomorrow.

@dedok
Copy link
Author

dedok commented Jun 22, 2016

I found some issues in docs - I trying to resolve them.
@arfoll You don't mind if I'll add full information about Lua in docs/lua.md and remove src/lua/docs?

@Hbrinj
Copy link
Contributor

Hbrinj commented Aug 1, 2016

Hows this going Dedok?

@dedok
Copy link
Author

dedok commented Aug 2, 2016

@Hbrinj Hi, in progress...
I'll prepare new PR, this one is out of date :)
I have already use this bindings and I have found some bugs, those bugs were fixed by me. But I didn't prepare the documentation for Lua API yet. Is this critical for you?

@Hbrinj
Copy link
Contributor

Hbrinj commented Aug 2, 2016

No it's not critical just wanted to see if things were going well :)

Sent from my iPhone

On 2 Aug 2016, at 20:29, Vasiliy Soshnikov [email protected] wrote:

@Hbrinj Hi, in progress...
I'll prepare new PR, this one is out of date :)
I have already use this bindings and I have found some bugs, those bugs were fixed by me. But I didn't prepare the documentation for Lua API yet. Is this critical for you?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@arfoll arfoll mentioned this pull request Aug 22, 2016
@arfoll
Copy link
Contributor

arfoll commented Oct 25, 2016

Any news on this? I'd love to merge an updated version of it

@drasko
Copy link

drasko commented Nov 14, 2016

Can somebody please merge this one? It's been here for months, and it is super-useful feature.

@dedok
Copy link
Author

dedok commented Nov 14, 2016

Sorry I forgot about it. I have to revert all changes in docs generating and merge changes from my fork after that it could be merged. Current, this fork have few bugs. Please give me more time.

@alext-mkrs
Copy link
Contributor

@dedok, so do you still plan to get this one updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants