Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java version from <1.8 to 17 #124 #125

Closed
wants to merge 1 commit into from
Closed

Conversation

jukzi
Copy link

@jukzi jukzi commented Aug 12, 2024

fixes #124

regular expression search and replace:

in org.eclipse.jdt.core.prefs:
(org.eclipse.jdt.core.compiler.codegen.targetPlatform|org.eclipse.jdt.core.compiler.compliance|org.eclipse.jdt.core.compiler.source)=.*
-> $1=17

in .classpath:
org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/([^"]*)
-> org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17

fixes eclipse#124

regular expression search and replace:

in org.eclipse.jdt.core.prefs:
   (org.eclipse.jdt.core.compiler.codegen.targetPlatform|org.eclipse.jdt.core.compiler.compliance|org.eclipse.jdt.core.compiler.source)=.*
-> $1=17

in .classpath:
   org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/([^"]*)
-> org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17
@eclipse-ecf-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it's likely these values aren't necessarily consistent with the MANIFEST.MF especially given none of the MANIFEST.MFs are changed by this PR.

@scottslewis
Copy link
Contributor

I haven't gone through all of these changes yet, but it's possible that many of the project level changes (to classpath, .prefs, etc) will require changes to MANIFEST.MF (for consistency...as Ed indicates) and so also will require increment of the service segment of the version number rather than just changing the qualifier.

I can't commit to doing that work in this release cycle, so I'm not going to merge this in.

@jukzi jukzi closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update java version
5 participants