GH-264: Xpect files cannot be launched in IDE under Java 9 #268
Conversation
Signed-off-by: Mark-Oliver Reiser <[email protected]>
Signed-off-by: Mark-Oliver Reiser <[email protected]>
Signed-off-by: Mark-Oliver Reiser <[email protected]>
Signed-off-by: Mark-Oliver Reiser <[email protected]>
Added here for consistency with how other dependencies are handled. Signed-off-by: Mark-Oliver Reiser <[email protected]>
Signed-off-by: Mark-Oliver Reiser <[email protected]>
Signed-off-by: Mark-Oliver Reiser <[email protected]>
|
please note: you should wait for the CQ to be approved before merging. |
| @@ -25,7 +25,8 @@ Require-Bundle: org.apache.log4j;bundle-version="1.2.0";visibility:=reexport, | |||
| org.eclipse.xtext.ecore;bundle-version="2.9.2";resolution:=optional, | |||
| org.objectweb.asm;bundle-version="[3.0.0,8.0.0)";resolution:=optional, | |||
| org.eclipse.equinox.common;bundle-version="3.0.0";resolution:=optional, | |||
| org.eclipse.core.runtime;bundle-version="3.0.0";resolution:=optional | |||
There was a problem hiding this comment.
i wonder if this should be added to the pom as dependency too for standalone calling from maven/gradle
There was a problem hiding this comment.
@dhuebner how do the maven artifacts you published deal with that issue? do they assume asm, equinox and others come from somewhere else/are added by the user?
There was a problem hiding this comment.
When using maven, isn't this handled by tycho?
There was a problem hiding this comment.
I just sag that the type id still eclipse bundle so the User has to take care about That itself (Same as for mwe)
There was a problem hiding this comment.
the maven artifact type is eclipse-bundle => if you use pure gradle or maven then you have to care about transtive dependencies yourself
There was a problem hiding this comment.
in mwe we do this. but i saw its not done in xpect in maven: https://github.com/eclipse/mwe/blob/9adfa2372a1d0d562734fbc8d9679357730b029e/plugins/org.eclipse.emf.mwe2.launch/pom.xml#L18
There was a problem hiding this comment.
this is a general problem and not related to this specific pr. added a comment here: #267 (comment)
|
CQ 20234 was approved (see https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20234) |
|
Since both the CQ for the classgraph library was approved by the EMO team, and @meysholdt approved #265 which has identical changes compared to this PR, I understand this PR to be OK for merge now. |
This PR contains the exact same changes as PR #265. All discussion / review happened there.
This PR was only created to fix issues with the eclipse/eca checker.