Repository navigation
[Draw2D] Introduce a new event listener for toggling redraw events - #1676
Merged
ptziegler merged 1 commit intoOct 31, 2026
Merged
Conversation
Rather than relying on the `refreshDispose` and `refreshed` events to disable and re-enable redraw events, the canvas lock is now set and released using a generic OSGi `EventHandler`. Rather than introducing yet another interface, the type of event is instead described via its topic. The problem with the previous implementation is that the `refreshDispose` event is fired from within the thread of the Designer, which might be either the SWT UI thread or the Swing Event Dispatcher thread. But changes to the `FigureCanvas` must always be done in the SWT UI thread. Rather than potentially breaking backwards compatibility by always executing said event in the SWT thread (which might also cause a deadlock when already in the Swing thread), this new event is now fired immediately before disposing the old model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than relying on the
refreshDisposeandrefreshedevents to disable and re-enable redraw events, the canvas lock is now set and released using a generic OSGiEventHandler. Rather than introducing yet another interface, the type of event is instead described via its topic.The problem with the previous implementation is that the
refreshDisposeevent is fired from within the thread of the Designer, which might be either the SWT UI thread or the Swing Event Dispatcher thread. But changes to theFigureCanvasmust always be done in the SWT UI thread. Rather than potentially breaking backwards compatibility by always executing said event in the SWT thread (which might also cause a deadlock when already in the Swing thread), this new event is now fired immediately before disposing the old model.