CoAP: Fix empty ack#861
Merged
LukasWoodtli merged 3 commits intoeclipse-wakaama:mainfrom Apr 3, 2025
Merged
Conversation
A received message was not processed if the mid does not match a pending operation. Now check token instead of only mid. Signed-off-by: Sebastian Schoch <sebastian.schoch@husqvarnagroup.com>
sarchey
force-pushed
the
gardena/ss/fix-empty-ack
branch
2 times, most recently
from
3d104cb to
3051569
Compare
When an empty ACK is received set the timeout for the separate response to COAP_SEPARATE_TIMEOUT. Signed-off-by: Sebastian Schoch <sebastian.schoch@husqvarnagroup.com>
sarchey
force-pushed
the
gardena/ss/fix-empty-ack
branch
from
3051569 to
ea90c22
Compare
mlasch
reviewed
Apr 3, 2025
|
|
||
| #define COAP_DEFAULT_MAX_AGE 60 | ||
| #define COAP_RESPONSE_TIMEOUT 2 | ||
| #define COAP_SEPARATE_TIMEOUT 15 |
Contributor
There was a problem hiding this comment.
It would be great to make this configurable from cmake.
sarchey
force-pushed
the
gardena/ss/fix-empty-ack
branch
from
aa9e7af to
ec90989
Compare
LukasWoodtli
force-pushed
the
gardena/ss/fix-empty-ack
branch
from
ec90989 to
5c0ea25
Compare
The timeout for separate ack can be configured with CMake variable. Signed-off-by: Sebastian Schoch <sebastian.schoch@husqvarnagroup.com>
LukasWoodtli
force-pushed
the
gardena/ss/fix-empty-ack
branch
from
5c0ea25 to
2460757
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoAP: Fix the implementation of the empty ACK and separate response mechanism