Clearly separate transport wire frame from actual message body wire frame. - #334
Merged
Conversation
…rame. Motivation: The event-bus grpc codec has two levels of codec which are currently coupled. The codec of the transport frame indicated by the endpoint wire format should be distinct from the stream wire format. Changes: Move the options wire format configuration at the endpoint level, this configures how transport frames are adverised and which codec to use, this configures the event bus message codec, used on the cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The event-bus grpc codec has two levels of codec which are currently coupled.
The codec of the transport frame indicated by the endpoint wire format should be distinct from the stream wire format.
Changes:
Move the options wire format configuration at the endpoint level, this configures how transport frames are adverised and which codec to use, this configures the event bus message codec, used on the cluster.