Cleaning up extra printed messages added during debugging #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhartley
requested changes
Apr 23, 2024
rpc/src/main_rpc_server.cpp
Outdated
| /* Build response attributes - the same UUID should be used to send the response | ||
| * it is also possible to send the response outside of the callback context */ | ||
| auto builder = UAttributesBuilder::response( | ||
| message.attributes().source(), |
There was a problem hiding this comment.
source is sink and sink is source so flip these two
rpc/src/main_rpc_server.cpp
Outdated
| auto builder = UAttributesBuilder::response( | ||
| message.attributes().source(), | ||
| message.attributes().sink(), | ||
| UPriority::UPRIORITY_CS0, |
There was a problem hiding this comment.
This needs to be message.attributes.priority().
gregmedd
force-pushed
the
cleanup/rpc-messages-for-timeout-issue
branch
from
4901523
to
244edfe
Compare
stevenhartley
approved these changes
Apr 24, 2024
stevenhartley
requested changes
Apr 24, 2024
rpc/src/main_rpc_server.cpp
Outdated
| auto builder = UAttributesBuilder::response( | ||
| message.attributes().sink(), | ||
| message.attributes().source(), | ||
| message.attributes.priority(), |
There was a problem hiding this comment.
Suggested change
| message.attributes.priority(), | |
| message.attributes().priority(), |
While debugging the RPC timeout issue, several extra messages were added and the reply data format were changed. Changing these back so the example is cleaner and outputs the expected time value.
gregmedd
force-pushed
the
cleanup/rpc-messages-for-timeout-issue
branch
from
244edfe
to
890ad14
Compare
stevenhartley
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the RPC timeout issue, several extra messages were added and the reply data format were changed. Changing these back so the example is cleaner and outputs the expected time value.