Add abstract Communication Layer API traits #124
Conversation
Added traits for publishing messages, sending notifications and invoking remote service operations. These traits represent the uProtocol Communication Layer API that uEntities can use to interact with each other using uProtocol.
sophokles73
force-pushed
the
add_abstract_l2_api
branch
from
5469eef
to
609eee1
Compare
| /// [Communication Layer API Specifications](https://github.com/eclipse-uprotocol/up-spec/blob/main/up-l2/api.adoc). | ||
| #[async_trait] | ||
| pub trait RpcServer: Send + Sync { | ||
| async fn register_endpoint( |
There was a problem hiding this comment.
Just in keeping with the other method declarations so far: do we want some docstrings here?
There was a problem hiding this comment.
Yes, definitely. Another thing I stumbled upon: for listeners to Publish messages it makes sense to be able to register multiple listeners for the same source address. However, I wonder if we should restrict the number of request listeners per (local) resource ID to one only. Otherwise you might end up in a situation where a client gets back multiple responses to its request. WDYT? @AnotherDaniel @evshary
There was a problem hiding this comment.
Yes, agree - also this would give implementors on server-side a little less rope to hang themselves with...
There was a problem hiding this comment.
Second it. I remember we had a conclusion that Notification and RPC should be 1-to-1, and Publish is 1-to-N in the weekly meeting. I think it will be more simplified.
| method: &UUri, | ||
| listener: Arc<dyn RpcClient>, | ||
| ) -> Result<(), RegistrationError>; | ||
| async fn unregister_endpoint( |
There was a problem hiding this comment.
Same comment as for register_endpoint()
Added traits for publishing messages, sending notifications and
invoking remote service operations. These traits represent the
uProtocol Communication Layer API that uEntities can use to
interact with each other using uProtocol.
This is the first step for #122