Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all L2 APIs to return responses asynchronously. #48

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Update all L2 APIs to return responses asynchronously. #48

merged 2 commits into from
Jul 10, 2024

Conversation

neelam-kushwah
Copy link
Contributor

This change updates all the communication layer APIs to return UStatus asynchronously. Methods now return UStatus upon success or complete with a UStatusError containing the relevant UStatus information upon failure

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Code coverage report is ready! 📈

@neelam-kushwah neelam-kushwah added the enhancement New feature or request label Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Code coverage report is ready! 📈

@matthewd0123
Copy link
Contributor

LGTM

stevenhartley
stevenhartley approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@stevenhartley stevenhartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thing I notice is that all the tests seem to run each operation synchronously by calling await. Is there a way you can test operations happening concurrently to ensure they are sequenced correctly?

@neelam-kushwah
Copy link
Contributor Author

yes, we can use asyncio.gather() to run multiple functions concurrently. I will add a test case in each file with asyncio.gather to ensure our tests cover concurrent operations.

@neelam-kushwah neelam-kushwah merged commit 4c00ec8 into eclipse-uprotocol:main Jul 10, 2024
3 checks passed
@neelam-kushwah neelam-kushwah deleted the async branch July 10, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhartley stevenhartley stevenhartley approved these changes

@matthewd0123 matthewd0123 matthewd0123 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neelam-kushwah @matthewd0123 @stevenhartley