Add support for the Zenoh Client's usage of the micro URI #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmedd
force-pushed
the
feature/1.5.7/zenoh-micro-uri
branch
from
3639c44
to
8d1fac3
Compare
debruce
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
I think this looks okay, and surely represents a large amount of work. However, I think it points to wider design issues, especially around the use of static methods instead of constructors, error propagation, absence of hashing methods for objects likely to be used as keys, etc.
The Zenoh client needs to serialize _just_ the UAuthority under some circumstances. To support this, that portion of MicroUriSerializer::serialize() has been split out into its own separate overload that is used both by the main UUri serializer and the Zenoh key converter.
gregmedd
force-pushed
the
feature/1.5.7/zenoh-micro-uri
branch
from
8d1fac3
to
0118557
Compare
stevenhartley
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec, the Zenoh client uses the micro URI serialization for UUri. However, it has support for one extra
**UUri mode that requires the ability to serialize only the UAuthority.This change splits out the UAuthority serialization into its own static method, which can be used both when serializing full UUris and when generating Zenoh keys for the
**mode.Note: This PR is dependent on #73 and cannot be merged until that PR is complete.