Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #206

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Code cleanup #206

merged 1 commit into from
Jul 11, 2024

Conversation

ruchirchauhan
Copy link
Contributor

Code cleanup

@github-actions GitHub Actions
Copy link

Code coverage report is ready! 📈

gregmedd
gregmedd requested changes Jul 11, 2024
View reviewed changes
test/coverage/communication/PublisherTest.cpp Outdated Show resolved Hide resolved
test/coverage/communication/PublisherTest.cpp Outdated Show resolved Hide resolved
test/coverage/communication/PublisherTest.cpp Show resolved Hide resolved
test/coverage/communication/PublisherTest.cpp Outdated Show resolved Hide resolved
test/coverage/communication/PublisherTest.cpp Outdated Show resolved Hide resolved
@ruchirchauhan ruchirchauhan force-pushed the test/communication/PublisherTest-cleanup branch from b9ce388 to e5b4c42 Compare July 11, 2024 13:09
@github-actions GitHub Actions
Copy link

Code coverage report is ready! 📈

@ruchirchauhan ruchirchauhan force-pushed the test/communication/PublisherTest-cleanup branch from e5b4c42 to 756a675 Compare July 11, 2024 14:02
@github-actions GitHub Actions
Copy link

Code coverage report is ready! 📈

gregmedd
gregmedd approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@gregmedd gregmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregmedd
Copy link
Contributor

One last request: Please revise the commit message to better describe the change. I recommend these guidelines when writing commit messages.

@ruchirchauhan
PublishTest cleanup
8f87882 
Remove unused headers, "using namespace" statements and debug logs
@ruchirchauhan ruchirchauhan force-pushed the test/communication/PublisherTest-cleanup branch from 756a675 to 8f87882 Compare July 11, 2024 17:15
@github-actions GitHub Actions
Copy link

Code coverage report is ready! 📈

@gregmedd gregmedd merged commit 34ff8f6 into eclipse-uprotocol:main Jul 11, 2024
12 checks passed
@ruchirchauhan
Copy link
Contributor Author

This should be ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmedd gregmedd gregmedd approved these changes

Assignees

@ruchirchauhan ruchirchauhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruchirchauhan @gregmedd