Publish Subscribe integrated test #203
Conversation
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
f23a8ff
to
2cff135
Compare
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
2cff135
to
92869a3
Compare
|
Code coverage report is ready! 📈
|
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
92869a3
to
24150d9
Compare
|
Code coverage report is ready! 📈
|
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
24150d9
to
fbed8f8
Compare
|
Code coverage report is ready! 📈
|
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
fbed8f8
to
9260da4
Compare
|
Code coverage report is ready! 📈
|
| EXPECT_EQ(AsString::serialize(topic_), | ||
| AsString::serialize(transportSub->sink_filter_)); |
There was a problem hiding this comment.
The URI check should probably be against the message and not the local variable:
| EXPECT_EQ(AsString::serialize(topic_), | |
| AsString::serialize(transportSub->sink_filter_)); | |
| EXPECT_EQ(AsString::serialize(transportMock_->message_.sink()), | |
| AsString::serialize(transportSub->sink_filter_)); |
There was a problem hiding this comment.
For publish message, sink is empty, I have changed it to transportMock_->message_.attributes().source()
There was a problem hiding this comment.
If that's the case, shouldn't it be checked against the source filter?
There was a problem hiding this comment.
@ruchirchauhan - this is still open. If publish methods can only have sources, then shouldn't they be checked against the source filter and not the sink filter?
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
9260da4
to
60a3139
Compare
|
Code coverage report is ready! 📈
|
|
This should be ready to be merged |
- This test tests the complete pub-sub flow to make sure data flows correctly through the pipeline.
ruchirchauhan
force-pushed
the
test/communication/pubsub
branch
from
60a3139
to
776b244
Compare
|
Code coverage report is ready! 📈
|
This test tests the complete pub-sub flow to make sure data flows correctly through the pipeline.