Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass UTransport's cleanup method for callbacks #153

Merged

Conversation

gregmedd
Copy link
Contributor

This method should be called when the CalleeHandle breaks the connection so that derived transports can clean up connections should they choose to do so. Enable this by passing a lambda that calls the method.

closes #152

@gregmedd gregmedd self-assigned this Jun 11, 2024
This method should be called when the `CalleeHandle` breaks the
connection so that derived transports can clean up connections should
they choose to do so. Enable this by passing a lambda that calls the
method.
@gregmedd gregmedd force-pushed the bugfix/1.5.8/152-utransport-cleanup branch from e661af9 to 0ce7ee8 Compare June 12, 2024 00:09
Copy link

@cbeck83 cbeck83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes is generally clear and concise.

@gregmedd gregmedd merged commit 555ebd9 into eclipse-uprotocol:main Jun 12, 2024
5 checks passed
@gregmedd gregmedd deleted the bugfix/1.5.8/152-utransport-cleanup branch June 18, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTransport does not provide the cleanup function when registering callbacks
2 participants