-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend demo bnd-workspace with subbundles #4661
Extend demo bnd-workspace with subbundles #4661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enhancing the example, we need some license headers on the java code and it would be good to squash all into one commit (it is the easier to later cherry pick/backport the test).
...e/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/impl/MarkdownRendererImpl.java
Show resolved
Hide resolved
...kspace/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/api/MarkdownRenderer.java
Show resolved
Hide resolved
de5eba7
to
9cb9035
Compare
...e/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/impl/MarkdownRendererImpl.java
Outdated
Show resolved
Hide resolved
...kspace/tycho.demo.markdown/src/main/java/tycho/demo/utils/markdown/api/MarkdownRenderer.java
Outdated
Show resolved
Hide resolved
638c519
to
641e7d0
Compare
32d9b76
to
41ce326
Compare
I can confirm that #4666 fixes the build of Note to self:
|
This now has failed the DemoTest#testTychoBndWorkspaceDemo in the CI as expected 👍 @chrisrueger can you please:
If that is done the test should be green again and we can already merge this! |
@laeubi will do. ? |
Use the current released version: |
41ce326
to
8ffc3aa
Compare
see the bnd.bnd of the new tycho.demo.markdown bundle. it uses the -sub: *.bnd instruction to create 2 jar files based on the other .bnd files (api.bnd and impl.bnd) Co-Authored-By: Christoph Läubrich <[email protected]>
8ffc3aa
to
9cbd37d
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
@chrisrueger thanks for enhancing the example! |
see the
bnd.bnd
of the newtycho.demo.markdown
bundle.it uses the
-sub: *.bnd
instruction to create 2 jar files based on the other .bnd files (api.bnd and impl.bnd)this build currently fails (which is intentional) and we want to use that to fix tycho to make it compile.
It seems that tycho currently does not recognize the 2 (sub) jars so it cannot find them as dependencies for the HelloWorldService
Expected result
The build should have produced two jars in
tycho.demo.markdown
And those should be recognized as dependency as required by the
-buildpath
of thetycho.demo.impl/bnd.bnd
, so thattycho.demo.impl
compiles successfully.