[tycho-4.0.x] Find reactor projects by location even if their file location changed #4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 603 files ±0 603 suites ±0 4h 27m 25s ⏱️ + 16m 50s For more details on these failures, see this check. Results for commit eaa6224. ± Comparison against base commit 33e6e92. |
Currently we cache the "known location" for an artifact, but for a reactor project this location can change (e.g. when it is finally packed to a jar). This leads to the unfortunate situation that we probably no longer find it in the map. This now first lookup the project with the map key, but if it is not found performs a deeper analysis of the artifacts and check if the location actually maps to the artifact location of the reactor project. If that is the case we use that instead of return nothing. Fix #4653 (cherry picked from commit 4d75930)
laeubi
force-pushed
the
backport/tycho-4.0.x/pr-4658
branch
from
eaa6224 to
f9a6b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation