Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all kinds of exceptions #4630

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Catch all kinds of exceptions #4630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...lugin/src/main/java/org/eclipse/tycho/baseline/provider/MavenArtifactVersionProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@
import org.eclipse.tycho.artifacts.ArtifactVersionProvider;
import org.eclipse.tycho.core.osgitools.BundleReader;
import org.eclipse.tycho.core.osgitools.OsgiManifest;
import org.eclipse.tycho.core.osgitools.OsgiManifestParserException;
import org.osgi.framework.BundleException;
import org.osgi.framework.VersionRange;
import org.osgi.framework.namespace.PackageNamespace;

Expand Down Expand Up @@ -169,7 +167,10 @@ private ModuleRevisionBuilder readOSGiInfo(Path path) {
try {
OsgiManifest manifest = bundleReader.loadManifest(path.toFile());
return OSGiManifestBuilderFactory.createBuilder(manifest.getHeaders());
} catch (BundleException | OsgiManifestParserException e) {
} catch (Exception e) {
// On maven there might be all kind of badly formated manifests ... if we can't
// parse it and create even a basic valid OSGi one than the artifacts is
// unlikely usable in OSGI context anyways
}
}
return null;
Expand Down
Loading