Handle class parsing errors more gracefully #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there can be some classes in the wild that can not be parsed by ASM, instead of completely fail, we just print the cause to the log and go on.
laeubi
force-pushed
the
handle_class_parse_errors
branch
from
2a373e6 to
a6ecf22
Compare
laeubi
added
the
backport-to-tycho-4.0.x
Test Results 606 files ±0 606 suites ±0 4h 20m 26s ⏱️ + 3m 10s For more details on these failures, see this check. Results for commit a6ecf22. ± Comparison against base commit 550125c. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there can be some classes in the wild that can not be parsed by ASM, instead of completely fail, we just print the cause to the log and go on.