Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducible timestamps in archives #4546

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

Zlika
Copy link
Contributor

@Zlika Zlika commented Dec 20, 2024

Use the standard "project.build.outputTimestamp" maven property to enable reproducible timestamps in archives (cf. https://maven.apache.org/guides/mini/guide-reproducible-builds.html).

@laeubi
Copy link
Member

laeubi commented Dec 20, 2024

@Zlika the failing test seem to be due to eclipse infra outages at the moment, but can you probably add
an integration-test to demonstrate the feature and make sure it actually works?

@Zlika
Copy link
Contributor Author

Zlika commented Dec 21, 2024

Hello @laeubi. I added integration tests.

@laeubi laeubi force-pushed the reproducible-timestamps branch from 3e00310 to f1b38aa Compare December 27, 2024 07:21
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Dec 27, 2024
@laeubi laeubi enabled auto-merge (rebase) December 27, 2024 08:30
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the enhancement.

To make people aware of this new feature you might want to add it to the release notes as well.

@laeubi laeubi force-pushed the reproducible-timestamps branch from f1b38aa to 8e572f5 Compare December 27, 2024 12:32
@laeubi
Copy link
Member

laeubi commented Dec 27, 2024

@HannesWell any idea why the license check do not run here?

@HannesWell
Copy link
Member

@HannesWell any idea why the license check do not run here?

My first guess is that it's not running because of not yet approved workflows. But then I wonder why it's even displayed as pending/waiting?

@Zlika
Copy link
Contributor Author

Zlika commented Dec 27, 2024

Looks good to me, thanks for the enhancement.

To make people aware of this new feature you might want to add it to the release notes as well.

It's just a first step towards reproducible builds with Tycho. More PR will come after this one has been merged. I will update the release note when the full feature is available.

@laeubi laeubi merged commit 87a514c into eclipse-tycho:main Dec 27, 2024
13 of 14 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

1 similar comment
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants