Revert "Add a flag to skip the service-component file check in packaging-plugin" #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-plugin" This reverts commit 2963a7a.
Test Results 603 files 603 suites 4h 14m 7s ⏱️ For more details on these failures, see this check. Results for commit 611007d. |
|
I would be fine with just keeping the flag, it is maybe seldom used but does not contribute to the complexity of the mojo nor limits its implementation. |
Sure that's also fine for me. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4280
For the intended use-case this is not necessary anymore and seems to be too specific for a general usage.
For the tycho 4.0.x-line I suggest to deprecate this for removal.
@laeubi Should we do the same for #4279? It's also not necessary anymore for the intended use-case, but seems to be more general and might be useful as such?