Adopt to new GPG Mojo

eclipse-tycho · Nov 4, 2024 · ed2b986 · ed2b986
1 parent cbcf9fa
commit ed2b986
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 4 deletions.
diff --git a/tycho-gpg-plugin/pom.xml b/tycho-gpg-plugin/pom.xml
@@ -25,6 +25,10 @@
 		<maven>${minimal-maven-version}</maven>
 	</prerequisites>
 	<dependencies>
+		<dependency>
+			<groupId>org.apache.maven</groupId>
+			<artifactId>maven-core</artifactId>
+		</dependency>
 		<dependency>
 			<groupId>org.apache.maven</groupId>
 			<artifactId>maven-plugin-api</artifactId>

diff --git a/tycho-gpg-plugin/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojoExtension.java b/tycho-gpg-plugin/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojoExtension.java
@@ -11,18 +11,21 @@
 
 import java.io.File;
 
-import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugin.MojoFailureException;
 import org.apache.maven.project.MavenProject;
 
 public abstract class AbstractGpgMojoExtension extends AbstractGpgMojo {
 
     @Override
-    protected ProxySignerWithPublicKeyAccess newSigner(MavenProject project)
-            throws MojoExecutionException, MojoFailureException {
+    protected ProxySignerWithPublicKeyAccess newSigner(MavenProject project) throws MojoFailureException {
         return new ProxySignerWithPublicKeyAccess(super.newSigner(project), getSigner(), getPGPInfo(), getSecretKeys());
     }
 
+    @Override
+    protected AbstractGpgSigner createSigner(String name) throws MojoFailureException {
+        return super.createSigner(getSigner());
+    }
+
     protected String getSigner() {
         return "gpg";
     }

diff --git a/...gpg-plugin/src/main/java/org/apache/maven/plugins/gpg/ProxySignerWithPublicKeyAccess.java b/...gpg-plugin/src/main/java/org/apache/maven/plugins/gpg/ProxySignerWithPublicKeyAccess.java
@@ -216,4 +216,14 @@ private String getKeys(boolean isPublic) throws MojoExecutionException {
             throw new MojoExecutionException("Unable to execute gpg command", e);
         }
     }
+
+    @Override
+    public String signerName() {
+        return signer.signerName();
+    }
+
+    @Override
+    public String getKeyInfo() {
+        return signer.getKeyInfo();
+    }
 }
diff --git a/tycho-gpg-plugin/src/main/java/org/eclipse/tycho/gpg/BouncyCastleSigner.java b/tycho-gpg-plugin/src/main/java/org/eclipse/tycho/gpg/BouncyCastleSigner.java
@@ -26,9 +26,11 @@
 import java.security.Security;
 import java.util.ArrayList;
 import java.util.Date;
+import java.util.Iterator;
 
 import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugins.gpg.AbstractGpgSigner;
+import org.apache.maven.plugins.gpg.BcSigner;
 import org.bouncycastle.bcpg.ArmoredOutputStream;
 import org.bouncycastle.bcpg.CompressionAlgorithmTags;
 import org.bouncycastle.bcpg.HashAlgorithmTags;
@@ -57,6 +59,7 @@
 import org.bouncycastle.openpgp.operator.bc.BcPGPDigestCalculatorProvider;
 import org.bouncycastle.openpgp.operator.bc.BcPGPKeyPair;
 import org.bouncycastle.openpgp.operator.jcajce.JcaPGPContentSignerBuilder;
+import org.bouncycastle.util.encoders.Hex;
 
 public class BouncyCastleSigner extends AbstractGpgSigner {
 
@@ -349,4 +352,18 @@ public static void main(String[] args) throws Exception {
             signer.generateSignature(target.toFile());
         }
     }
+
+    @Override
+    public String signerName() {
+        return BcSigner.NAME;
+    }
+
+    @Override
+    public String getKeyInfo() {
+        Iterator<String> userIds = secretKey.getPublicKey().getUserIDs();
+        if (userIds.hasNext()) {
+            return userIds.next();
+        }
+        return Hex.toHexString(secretKey.getPublicKey().getFingerprint());
+    }
 }
diff --git a/tycho-gpg-plugin/src/main/java/org/eclipse/tycho/gpg/SignRepositoryArtifactsMojo.java b/tycho-gpg-plugin/src/main/java/org/eclipse/tycho/gpg/SignRepositoryArtifactsMojo.java
@@ -166,7 +166,7 @@ protected File getSecretKeys() {
     }
 
     @Override
-    public void execute() throws MojoExecutionException, MojoFailureException {
+    public void doExecute() throws MojoExecutionException, MojoFailureException {
 
         var signer = newSigner(project);
         var keys = KeyStore.create();