fix(ports): move tx_initialize_low_level.S to example_build for M33/M55/M85 GNU#514
Conversation
…x-M33/M55/M85 GNU (eclipse-threadx#452) The Cortex-M33, M55, and M85 GNU ports incorrectly include tx_initialize_low_level.S as a library source in CMakeLists.txt. This file is board-specific initialization code that users must customize for their hardware, and including it in the library causes linker conflicts when users provide their own implementation (e.g., via CMake FetchContent). This change aligns these ports with the established pattern used by Cortex-M0/M3/M4/M7 GNU ports: - Move tx_initialize_low_level.S from src/ to example_build/ - Remove it from CMakeLists.txt target_sources - Add sample_threadx.c to example_build/ for consistency Signed-off-by: An Dao <webmaster@taktflow-systems.com>
5849440 to
210bc6e
Compare
|
Thank you for this contribution, @nhuvaoanh123. Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record. Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org. Be sure to use the same email address when you register for the account that you intend to use on Git commit records. Also, please add your GitHub ID to your Eclipse account. This enables synchronisation between Eclipse-owned infrastructure and GitHub. Here is the link to sign the ECA: |
|
Thanks @fdesbiens! I've signed the ECA using |
|
@nhuvaoanh123, I checked your Eclipse account, and there is no GitHub ID in it. Can you please add it? Otherwise, our backend system cannot sync with GitHub. |
|
Hi @fdesbiens, I have now linked my GitHub ID (nhuvaoanh123) to my Eclipse account. Could you please check again? The account was signed with the same email address used for my Git commits. Thank you! |
Summary
Fixes #452
The Cortex-M33, M55, and M85 GNU ports incorrectly include
tx_initialize_low_level.Sas a library source inCMakeLists.txt. This file is board-specific initialization code that users must customize for their hardware. Including it in the library causes linker conflicts (duplicate symbol_tx_initialize_low_level) when users provide their own implementation via CMakeFetchContent.This PR aligns these three ports with the established pattern used by Cortex-M0/M3/M4/M7 GNU ports:
tx_initialize_low_level.Sfromsrc/toexample_build/(reference template only)tx_initialize_low_level.Sentry fromCMakeLists.txttarget_sourcessample_threadx.ctoexample_build/for consistency with other portsCMakeLists.txtformatting with the{{BEGIN/END_TARGET_SOURCES}}markers used by other portsPorts affected
cortex_m33/gnusrc/+ in CMakeexample_build/onlycortex_m55/gnusrc/+ in CMakeexample_build/onlycortex_m85/gnusrc/+ in CMakeexample_build/onlyReference (correct pattern)
ports/cortex_m4/gnu/—tx_initialize_low_level.Sinexample_build/, not referenced inCMakeLists.txtTest plan
CMakeLists.txtno longer referencestx_initialize_low_level.Sexample_build/containstx_initialize_low_level.S+sample_threadx.cfor all three portsSigned-off-by: An Dao webmaster@taktflow-systems.com