Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing CMakeLists.txt for Renesas RX ports #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spir6s
Copy link

@spir6s spir6s commented Nov 28, 2024

Added missing CMakeLists.txt for the following Renesas RX ports:

  • rxv1/ccrx
  • rxv1/gnu (tested)
  • rxv2/ccrx
  • rxv2/gnu (only added missing files)
  • rxv3/ccrx
  • rxv3/gnu (tested)

@fdesbiens
Copy link

Hi @spir6s.

Thank you for this contribution!

Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record.

Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org.

Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

Here is the link to sign the ECA:
https://accounts.eclipse.org/user/login?destination=user/eca

@spir6s
Copy link
Author

spir6s commented Dec 20, 2024

Hi @fdesbiens,

I have just accepted the ECA.

Please let me know if there are other things missing.

@fdesbiens fdesbiens self-assigned this Jan 6, 2025
Copy link

@fdesbiens fdesbiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this contribution.

@fdesbiens
Copy link

Hi @spir6s.

I hope you had a good holiday. Happy 2025!

The ECA check still fails. This is because your Eclipse account uses a "googlemail.com" address while your commits seem to be signed with your corporate one.

There are two ways to fix this. Either update your Eclipse account to use your corporate email or submit a PR signed with your googlemail address.

Thank you for your cooperation. I reviewed the changes so I will merge as soon as we fix the ECA.

@spir6s
Copy link
Author

spir6s commented Jan 6, 2025

Hi @fdesbiens,

thanks! I hope you had good holidays too.

I've changed my Eclipse account back to the corporate one. Actually I've been using it with the corporate address from the beginning on, but thought it has to have the same adress as my GitHub accout for the PR.

@fdesbiens
Copy link

An update from me, @spir6s. You did what you needed to but, somehow, the ECA check still does not pass. I am troubleshooting this with our IT team. Thank you for your patience.

@fdesbiens
Copy link

@spir6s Our IT team determined that the issue needs a deeper investigation. Could you please create a HelpDesk ticket?

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues

You can log into GitLab using your Eclipse Foundation account.

Please tag my colleague Martin Lowe and me on the ticket. Martin is responsible for the code of the ECA checker and will determine whether the problem is with your account or the code.

Thank you for your patience and support.

@spir6s
Copy link
Author

spir6s commented Jan 11, 2025

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants