-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing CMakeLists.txt for Renesas RX ports #423
base: master
Are you sure you want to change the base?
Conversation
Hi @spir6s. Thank you for this contribution! Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record. Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org. Be sure to use the same email address when you register for the account that you intend to use on Git commit records. Here is the link to sign the ECA: |
Hi @fdesbiens, I have just accepted the ECA. Please let me know if there are other things missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for this contribution.
Hi @spir6s. I hope you had a good holiday. Happy 2025! The ECA check still fails. This is because your Eclipse account uses a "googlemail.com" address while your commits seem to be signed with your corporate one. There are two ways to fix this. Either update your Eclipse account to use your corporate email or submit a PR signed with your googlemail address. Thank you for your cooperation. I reviewed the changes so I will merge as soon as we fix the ECA. |
Hi @fdesbiens, thanks! I hope you had good holidays too. I've changed my Eclipse account back to the corporate one. Actually I've been using it with the corporate address from the beginning on, but thought it has to have the same adress as my GitHub accout for the PR. |
An update from me, @spir6s. You did what you needed to but, somehow, the ECA check still does not pass. I am troubleshooting this with our IT team. Thank you for your patience. |
@spir6s Our IT team determined that the issue needs a deeper investigation. Could you please create a HelpDesk ticket? https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues You can log into GitLab using your Eclipse Foundation account. Please tag my colleague Martin Lowe and me on the ticket. Martin is responsible for the code of the ECA checker and will determine whether the problem is with your account or the code. Thank you for your patience and support. |
Done |
Added missing CMakeLists.txt for the following Renesas RX ports: