Launch Yeoman Generator in separate thread #6

vitaliy-guliy · 2019-12-26T09:06:29Z

As VS Code extension generator goes not take in attention an option specifying the directory for generated projects, it always generate a project into current working directory.
The idea was to run Yeoman generator in separate node instance and change current working directory to /projects.

Fixes issue eclipse-che/che#15443

Subtask of eclipse-che/che#14228

Signed-off-by: Vitaliy Gulyy <[email protected]>

benoitf · 2020-01-09T13:44:13Z

src/theia-yeoman-backend-plugin.ts

@@ -0,0 +1,38 @@
+/*********************************************************************
+* Copyright (c) 2018 Red Hat, Inc.


as you're doing a refactoring, copyright date needs to be updated

benoitf · 2020-01-09T13:44:33Z

src/yeoman-process-adapter.ts

@@ -0,0 +1,221 @@
+/*********************************************************************
+* Copyright (c) 2018 Red Hat, Inc.


please update

benoitf · 2020-01-09T13:44:41Z

src/yeoman-process-adapter.ts

+const path = require('path');
+const fork = require('child_process').fork;
+
+export class YeomanProcessAdapter {


please comment

Strange, GitHub does not display the changes but they are present
https://github.com/vitaliy-guliy/theia-yeoman-plugin/blob/separate-thread/src/yeoman-process-adapter.ts

benoitf · 2020-01-09T13:47:04Z

src/yeoman-process-adapter.ts

+        const currentWorkspace = workspaceFolders[0];
+
+        // start Yeoman generator in separate node instance
+        const scriptPath = this.extensionPath + '/lib/yeoman-process.js';


we should use Path.resolve no ?

benoitf · 2020-01-09T13:47:45Z

src/yeoman-process-adapter.ts

+        child.on('message', this.onMessage);
+
+        child.stdout.on('data', (data: any) => {
+            console.log(`## stdout: ${data}`);


why do we need to output to the console stdout or stderr ?

It helps us to understand the reason when something goes wrong.
Once it helped me to catch an error when running the generator.

why it's not part of the output on the UI side then ?

IMHO we shouldn't pollute that console by default (= not when debugging)

UI displays only the messages related to creating the extension.
The messages form stdout / stderr are printed to Theia backend console, which is not visible in Theia.
It's easy to ignore them, but should we?

I have reworked it a bit. All the output has been printed to the UI. Looks nice.

benoitf · 2020-01-09T13:48:55Z

src/yeoman-process.ts

+
+const proc = process;
+
+export class YeomanProcess {


please comment ?

benoitf · 2020-01-09T13:54:06Z

Hello,
in the current code (before your pull request), it's doing:

    const currentWorkspace = workspaceFolders[0];	
    yeomanOpts.cwd = currentWorkspace.uri.path;	
    const yeomanEnvironment = yeoman.createEnv(undefined, yeomanOpts, new TheiaYeomanAdapter());

so AFAIK it launches yeoman from the workspace folder which should be /projects no ?
why do we need a fork process ?

vitaliy-guliy · 2020-01-09T14:27:08Z

Hello,
in the current code (before your pull request), it's doing:
    const currentWorkspace = workspaceFolders[0];	
    yeomanOpts.cwd = currentWorkspace.uri.path;	
    const yeomanEnvironment = yeoman.createEnv(undefined, yeomanOpts, new TheiaYeomanAdapter());
so AFAIK it launches yeoman from the workspace folder which should be /projects no ?
why do we need a fork process ?

VS Code extension generator does not take into account cwd configuration property and always generate the project into current working directory, which is /home/theia. That's why we need to launch a separate process and change the working directory on /projects.

In the current code, VS Code yeoman generator is running in current node instance, not in separate.

Signed-off-by: Vitaliy Gulyy <[email protected]>

Signed-off-by: Vitaliy Guliy <[email protected]>

benoitf

I tested. Works fine.

FYI build is failing with CI
Probably you need to replace theia:plugin by theia-plugin in package.json file

vitaliy-guliy · 2020-01-13T13:19:59Z

I tried to do it before. You could scroll up to see the commit where I returned it back to 'theia:plugin'.
On the local machine 'theia-plugin' does not work also

yarn run v1.17.3
$ yarn run format-code && yarn run compile && yarn run tslint-fix && theia-plugin pack
$ tsfmt -r
$ tsc
$ tslint --fix --project .
/bin/sh: 1: theia-plugin: not found
error Command failed with exit code 127.

vitaliy-guliy · 2020-01-13T13:26:45Z

@benoitf could you merge this PR? It seems only you have right do it.

benoitf · 2020-01-13T13:29:30Z

I can merge but we need to fix first the ci issue else it won't be built and then it won't be available

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy force-pushed the separate-thread branch from 69fb4e4 to deca66b Compare December 26, 2019 09:59

vitaliy-guliy mentioned this pull request Dec 26, 2019

Fix quick pick menu #5

Closed

Run Yeoman generator in separate node instance

0282392

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy force-pushed the separate-thread branch from bd5e646 to 0282392 Compare December 26, 2019 13:49

Update package.json

9230458

Signed-off-by: Vitaliy Gulyy <[email protected]>

benoitf reviewed Jan 9, 2020

View reviewed changes

vitaliy-guliy added 2 commits January 10, 2020 15:52

Add comments

0153884

Signed-off-by: Vitaliy Gulyy <[email protected]>

Print output to UI

1ad5b59

Signed-off-by: Vitaliy Guliy <[email protected]>

benoitf approved these changes Jan 13, 2020

View reviewed changes

Use new theia plugin packager

99c454b

Signed-off-by: Vitaliy Gulyy <[email protected]>

benoitf merged commit 7a0f742 into eclipse-theia:master Jan 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Launch Yeoman Generator in separate thread #6

Launch Yeoman Generator in separate thread #6

vitaliy-guliy commented Dec 26, 2019 •

edited

Loading

benoitf Jan 9, 2020

vitaliy-guliy Jan 10, 2020

benoitf Jan 9, 2020

vitaliy-guliy Jan 10, 2020

benoitf Jan 9, 2020

vitaliy-guliy Jan 10, 2020

vitaliy-guliy Jan 10, 2020

benoitf Jan 9, 2020

vitaliy-guliy Jan 10, 2020

benoitf Jan 9, 2020

vitaliy-guliy Jan 10, 2020

benoitf Jan 10, 2020

vitaliy-guliy Jan 11, 2020

vitaliy-guliy Jan 11, 2020

benoitf Jan 9, 2020

vitaliy-guliy Jan 10, 2020

benoitf commented Jan 9, 2020 •

edited

Loading

vitaliy-guliy commented Jan 9, 2020

benoitf left a comment

vitaliy-guliy commented Jan 13, 2020

vitaliy-guliy commented Jan 13, 2020

benoitf commented Jan 13, 2020

		@@ -0,0 +1,38 @@
		/*********************************************************************
		* Copyright (c) 2018 Red Hat, Inc.

		@@ -0,0 +1,221 @@
		/*********************************************************************
		* Copyright (c) 2018 Red Hat, Inc.

Launch Yeoman Generator in separate thread #6

Launch Yeoman Generator in separate thread #6

Conversation

vitaliy-guliy commented Dec 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoitf commented Jan 9, 2020 • edited Loading

vitaliy-guliy commented Jan 9, 2020

benoitf left a comment

Choose a reason for hiding this comment

vitaliy-guliy commented Jan 13, 2020

vitaliy-guliy commented Jan 13, 2020

benoitf commented Jan 13, 2020

vitaliy-guliy commented Dec 26, 2019 •

edited

Loading

benoitf commented Jan 9, 2020 •

edited

Loading